On Wed, May 19, 2010 at 12:59 PM, Robert Haas <robertmh...@gmail.com> wrote: > In terms of removing the backup label file, can we simply have an > additional boolean in the postmaster that indicates whether we've ever > reached PM_RUN, and only consider removing the backup file if so?
Yes, but I prefer XLogCtl->SharedRecoveryInProgress, which is the almost same indicator as the boolean you suggested. Thought? >>>> ISTM that walreceiver might be invoked even after shutdown is requested. >>>> We should prevent the postmaster from starting up walreceiver if >>>> Shutdown > NoShutdown? >>> >>> Well, when we did the previous shutdown patch, we decided it was not >>> right to kill walreceiver until all backends had exited, so it seems >>> inconsistent to make the opposite decision here. >> >> Oh, right. How about allowing the postmaster only in PM_STARTUP, >> PM_RECOVERY, PM_HOT_STANDBY or PM_WAIT_READONLY state to invoke >> walreceiver? We can keep walreceiver alive until all read only >> backends have gone, and prevent unexpected startup of walreceiver. > > Yes, that seems like something we should be checking, if we aren't already. I'll do that. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
