It looks good to me: (0) new patch applies cleanly to CVS HEAD; (1) the formating of the code was changed; (2) definition of the HYPOT macro was changed to use phypot rather than being removed; (3) the phypot function was declared to be extern; (4) the comments to the phypot function were changed to remove the reference about the SUS behavior.
I changed the status to "Ready for Committer". Thanks Andrew On Fri, Jul 23, 2010 at 4:01 PM, Kevin Grittner <kevin.gritt...@wicourts.gov> wrote: > Tom Lane <t...@sss.pgh.pa.us> wrote: > >> I think the patch is good in principle > > Since everyone seems to agree this is a good patch which needed > minor tweaks, and we haven't heard from the author, I just went > ahead and made the changes. > > Andrew, could you take another look and see if you agree I've > covered it all before it gets marked ready for a committer? > > -Kevin > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
