On Tue, Sep 7, 2010 at 12:55 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote: > 2010/9/7 Teodor Sigaev <teo...@sigaev.ru>: >> Hm, what is aim of this hook? It looks like a wrapper of dictionary init >> method. > > If I use a mmap for shared dictionary, then I have to prealloc and > maybe preread dictionary - it can be done in external module. But I > have to join preloaded dictionary to requested dictionary. This hook > allows this relation - and it's general - I don't need any special > support in ispell dictionary.
Review: 1. Is this really necessary? It seems that you're inserting a hook here when you could just as well change tmplinit to point to whatever function you want to call, which wouldn't require a code change. 2. Our standard criteria for the inclusion of a hook is some sample code that demonstrates how it can be usefully used. I think you need to provide that before we can consider this further. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
