On Wed, Dec 29, 2010 at 04:53:47PM -0500, Robert Haas wrote: > On Wed, Dec 29, 2010 at 4:09 AM, Heikki Linnakangas > <heikki.linnakan...@enterprisedb.com> wrote: > > On 29.12.2010 06:54, Robert Haas wrote: > >> > >> With the patch: > >> > >> rhaas=# cluster v; > >> ERROR: views do not support CLUSTER > > > > "do not support" sounds like a missing feature, rather than a nonsensical > > command. How about something like "CLUSTER cannot be used on views" > > In the latest version of this patch, I created four translatable > strings per object type: > > <blats> do not support %s (where %s is an SQL command) > <blats> do not support constraints > <blats> do not support rules > <blats> do not support triggers > > It's reasonable enough to write "CLUSTER cannot be used on views", but > does "constraints cannot be used on views" seems more awkward to me. > Or do we think that's OK?
That particular one looks good insofar as it describes reality. With predicate locks, etc., it may become untrue later, though :) Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
