On Wed, Dec 29, 2010 at 4:09 AM, Heikki Linnakangas <heikki.linnakan...@enterprisedb.com> wrote: > On 29.12.2010 06:54, Robert Haas wrote: >> >> With the patch: >> >> rhaas=# cluster v; >> ERROR: views do not support CLUSTER > > "do not support" sounds like a missing feature, rather than a nonsensical > command. How about something like "CLUSTER cannot be used on views"
I'm fine with flipping the ordering around. I think I like it marginally better this way, but you and Tom both seem to prefer the opposite ordering, ergo so be it (barring a sudden influx of contrary votes). > The patch changes a bunch of heap_openrv() calls to relation_openrv(). > Perhaps it would be better make the error message something like "\"%s\" is > not a table", and keep the callers unchanged. It's not particularly useful > to repeat the command in the error message, the user should know what > command he issued. Even if it's buried deep in a PL/pgSQL function or > something, it should be clear from the context lines. Did you read the whole thread? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
