On Sun, Jan 23, 2011 at 9:56 PM, Robert Haas <[email protected]> wrote: > On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas <[email protected]> wrote: >> 2011/1/21 KaiGai Kohei <[email protected]>: >>> The attached patch is a revised version. >> >> I've committed this. Cleanup coming... > > Yikes. On further examination, exec_object_restorecon() is pretty > bogus. Surely you need some calls to quote_literal_cstr() in there > someplace. And how about using getObjectDescriptionOids() for the > error message, instead of the entirely bogus construction that's there > now?
Also, shouldn't a bunch of these messages end in ": %m"? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
