Simon Riggs wrote: > On Sun, Jun 12, 2011 at 2:23 AM, Robert Haas <robertmh...@gmail.com> wrote: > > On Sat, Jun 11, 2011 at 9:15 PM, Joshua D. Drake <j...@commandprompt.com> > > wrote: > >> On 6/11/2011 1:23 PM, Bruce Momjian wrote: > >>> > >>>> There is a difference between a project name and something that directly > >>>> affects usability. +1 on fixing this. IMO, we don't create a new pid > >>>> column, we just fix the problem. If we do it for 9.2, we have 18 months > >>>> to communicate the change. > >>> > >>> Uh, I am the first one I remember complaining about this so I don't see > >>> why we should break compatibility for such a low-level problem. > >> > >> Because it is a very real problem with an easy fix. We have 18 months to > >> publicize that fix. I mean really? This is a no-brainer. > > > > I really don't see what the big deal with calling it the process PID > > rather than just the PID is. ?Changing something like this forces > > pgAdmin and every other application out there that is built to work > > with PG to make a code change to keep working with PG. ?That seems > > like pushing a lot of unnecessary work on other people for what is > > basically a minor cosmetic issue. > > +1 > > If we were going to make changes like this, I'd suggest we save them > up in a big bag for when we change major version number. Everybody in > the world thinks that PostgreSQL v8 is compatible across all versions > (8.0, 8.1, 8.2, 8.3, 8.4), and it will be same with v9. That way we > would still have forward progress, but in more sensible sized steps. > Otherwise we just break the code annually for all the people that > support us. If we had a more stable environment for tools vendors, > maybe people wouldn't need to be manually typing procpid anyway...
Agreed. I did add a C comment that this was misnamed so when we are in that code we will see it. I did reorder the pg_stat_activity columns in 9.0 for sanity, and no one complained, but renaming is more disruptive than reordering. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
