Excerpts from Magnus Hagander's message of mié jun 22 11:25:43 -0400 2011: > On Fri, Jun 10, 2011 at 21:07, Tom Lane <[email protected]> wrote: > > Magnus Hagander <[email protected]> writes: > >> I came across a situation today with a pretty bad crash of pg_dump, > >> due to not checking the return code from malloc(). When looking > >> through the code, it seems there are a *lot* of places in pg_dump that > >> doesn't check the malloc return code. > > > >> But we do have a pg_malloc() function in there - but from what I can > >> tell it's only used very sparsely? > > > >> Shouldn't we be using that one more or less everywhere > > > > Yup. Have at it. > > Something along the line of this?
Huh, do you really need a new file for the four new functions? What's wrong with common.c? -- Álvaro Herrera <[email protected]> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
