On 2011-07-22 11:55, Kohei Kaigai wrote:

2) Also I thought if it could work to not remember tcontext is valid, but 
instead remember the consequence,
which is that it is replaced by "unlabeled". It makes the avc_cache struct 
shorter and the code somewhat
simpler.

Here is a reason why we hold tcontext, even if it is not valid.
The hash key of avc_cache is combination of scontext, tcontext and tclass. 
Thus, if we replaced an invalid
tcontext by unlabeled context, it would always make cache mishit and 
performance loss.
I see that now, thanks.

I have no further comments, and I think that the patch in it's current status is ready for committer.

regards,
--

Yeb Havinga
http://www.mgrid.net/
Mastering Medical Data


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to