On Thu, Sep 1, 2011 at 9:25 AM, Robert Haas <robertmh...@gmail.com> wrote: > Committed, with some changes. I used the new --if-exists option for > dropdb rather than doing it as you had it here; I assume this may have > been the motivation for that patch.
Thanks, and that was indeed one reason I wanted dropdb --if-exists. > I also just made the exit code 1 > no matter how many failures there were. That seems more normal, and I > wasn't altogether certain that $((expr)) is completely portable. Yeah, I wasn't sure about that either. The old book "The Unix Programming Environment" (section "Arithmetic in sh") claims that using expr or bc is the only way to do such arithmetic, e.g.: var=`expr $var + 1` But then [1] documents arithmetic expansion as used in the patch. But anyway, just returning 1 as you've done seems fine. Josh [1] http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_04 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
