On Mon, Sep 26, 2011 at 10:37, Magnus Hagander <mag...@hagander.net> wrote: > On Sun, Sep 25, 2011 at 15:06, Dean Rasheed <dean.a.rash...@gmail.com> wrote: >> On 24 September 2011 11:59, Magnus Hagander <mag...@hagander.net> wrote: >>> TABLE tab completion in psql only completes to tables, not views. but >>> the TABLE command works fine for both tables and views (and also >>> sequences). >>> >>> Seems we should just complete it to relations and not tables - or can >>> anyone see a particular reason why we shouldn't? >>> >> >> Doesn't that mean that "DROP TABLE <tab>" would offer up views as well >> as tables, which would be incorrect? > > Meh - you are correct, of course. I guess that's why we have code review :-) > > So - not a oneliner, but how about something like this? > > (Happy to have someone point out a neater way of doing it, not > entirely fluent in how we do the tab completion..)
Rebased on top of the changes Tom made to the infrastructure, and applied. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
