On Fri, Oct 28, 2011 at 3:27 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Fri, Oct 28, 2011 at 2:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Hmm. I wonder whether it wouldn't be better to get rid of the range >>> checks in BufferIsValid, or better convert them into Asserts. It seems >>> less than intuitive that BufferIsValid and BufferIsInvalid aren't simple >>> inverses. > >> Seems reasonable. It would break if anyone is using an out-of-range >> buffer number in lieu of InvalidBuffer, but I doubt that anyone is. > > Yeah, I find that unlikely as well. But leaving Asserts in place would > tell us.
OK. Should I go do that, or are you all over it? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers