On 11/29/2011 04:32 PM, Brar Piening wrote:
Andrew Dunstan wrote:

Some minor nitpicks:

Do we really need to create all those VSnnnnProject.pm and VSnnnnSolution.pm files? They are all always included anyway. Why not just stash all the packages in Solution.pm and Project.pm?
We certainly don't *need* them.
Having different files separates the tasks of generating different target file formats into different source files. In my opinion this makes it easier to find the code that is actually generating the files that get used in a specific build environment. While the VSnnnnSolution.pm and VC200nProject.pm files are indeed not much more than stubs that could eventually be extended in future (and probably never will) VC2010Project.pm contains the whole code for generating the new file format which would significantly bloat up the code in Project.pm that currently contains the common code for generating the old file formats.

Does anyone else have an opinion on this. I want to wrap this up ASAP so we can get a VS2010 buildfarm member working.



Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to