Peter Eisentraut <> writes:
> On mån, 2012-01-09 at 14:04 -0500, Tom Lane wrote:
>> #ifdef CATALOG_VARLEN           /* variable-length fields start here
>> */
>> to be even clearer.
>> What would be appropriate to add instead of those inconsistently-used
>> comments is explicit comments about the exception cases such as
>> proargtypes, to make it clear that the placement of the #ifdef
>> CATALOG_VARLEN is intentional and not a bug in those cases.

> I implemented your suggestions in the attached patch.

This looks ready to go to me, except for one trivial nit: in
pg_extension.h, please keep the comment pointing out that extversion
should never be null.

                        regards, tom lane

Sent via pgsql-hackers mailing list (
To make changes to your subscription:

Reply via email to