(2012/03/05 21:00), Etsuro Fujita wrote: > (2012/03/05 18:21), Shigeru Hanada wrote: >> (2012/02/21 20:25), Etsuro Fujita wrote: >>> Please find attached an updated version of the patch. >> >> This v2 patch can be applied on HEAD cleanly. Compile completed with >> only one expected warning of scan.c, and all regression tests for both >> core and contrib modules passed. >> >> This patch allows FDWs to return multiple ForeignPath nodes per a >> PlanForeignScan call. It also get rid of FdwPlan, FDW-private >> information container, by replacing with simple List. >> >> I've reviewed the patch closely, and have some comments about its design. > > Thank you for your review. > >> Basically a create_foo_path is responsible for creating a node object >> with a particular Path-derived type, but this patch changes >> create_foreignscan_path to just call PlanForeignScan and return void. >> This change seems breaking module design. > > create_index_path builds multiple index paths for a plain relation. How > about renaming the function to create_foreign_paths?
I meant "create_foreignscan_paths". I'm sorry about that. Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers