On 21.09.2012 00:10, Selena Deckelmann wrote:
Hello!
I've spent a little time with this patch and have attached revision 6.
Thanks, Noah, for a fantastically detailed review.
The only thing I didn't do that Noah suggested was run pgindent on
guc-file.l. A cursory search did not reveal source compatible with my
operating system for 'indent'. If someone points me to it, I'd happily
also comply with the request to reindent. And document how to do that
on my platform(s). :)
I did just remove the references to the Apache project etc. I agree
that providing best practices is good, but I'm skeptical about
including best practices piecemeal. Adding it to earlier tutorial
sections would probably be a bit more visible IMO.
This seems pretty much ready to commit. One tiny detail that I'd like to
clarify: the docs say:
Multiple files within an include directory are ordered by an alphanumeric
sorting, so that ones beginning with numbers are considered before those
starting with letters.
To be more precise, the patch uses strcmp() for the comparisons. That's
also what apache seems to do, although I couldn't find it being
mentioned explicitly in their docs. It's true that numbers are sorted
before letters, but should we also mention that upper-case letters are
sorted before lower-case ones, and that sorting of non-ASCII characters
depends on the encoding, in often surprising ways? Is there a better
term for what strcmp() does? ASCII order? Is there precedence somewhere
else in the PostgreSQL codebase or docs for that?
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
