On 09/29/2012 01:49 PM, Andrew Dunstan wrote:
On 09/29/2012 11:49 AM, Tom Lane wrote:
Andrew Dunstan <and...@dunslane.net> writes:
The recent alter generic tests have broken pg_upgrade testing on
Windows
and probably other non-collation-supporting platforms.
Is it still broken after Alvaro added the alternate expected file, and
if so why? I don't see a reason that this should be failing only there.
I also note that it seems to be passing fine on buildfarm members other
than pitta.
Well, that's a very good point. chough is actually the same machine,
doing an MSVC build. So why would this test pass there? I'll
investigate a bit more. Here's what the regression diffs look like
when run from pg_upgrade on pitta:
[hours of digging later]
It turns out that the reason is that we support collations on MSVC but
not on Mingw.
*sigh*
I'll have to put it on my ever lengthening TODO list.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers