On Thu, 2012-10-18 at 15:09 -0300, Alvaro Herrera wrote:
> Jeff, do you think we need more review of this patch?
In the patch, it refers to rd_options without checking for NULL first,
which needs to be fixed.
There's actually still one place where it says "id" rather than "is".
Just a nitpick.
Regarding my point 4 from the previous email, I mildly disagree with the
style, but I don't see a correctness problem there.
If the first two items are fixed, then the patch is fine with me.
Regards,
Jeff Davis
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
