On Mon, 2012-12-03 at 13:16 +0000, Simon Riggs wrote: > On 3 December 2012 09:56, Simon Riggs <si...@2ndquadrant.com> wrote: > > > I think the way forwards for this is... > > > > 1. Break out the changes around inCommit flag, since that is just > > uncontroversial refactoring. I can do that. That reduces the noise > > level in the patch and makes it easier to understand the meaningful > > changes. > > Done.
Thank you. One minor thing I noticed: it looks like nwaits is a useless variable. Your original checksums patch used it to generate a warning, but now that is gone. It's not throwing a compiler warning for some reason. Regards, Jeff Davis -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers