On 17.12.2012 11:04, Pavan Deolasee wrote:
On Mon, Dec 17, 2012 at 2:00 PM, Heikki Linnakangas
<hlinnakan...@vmware.com>  wrote:
On 16.12.2012 16:16, Andres Freund wrote:

Now that XLRecPtr's are plain 64bit integers what are we supposed to use
in code comparing and manipulating them? There already is plenty example
of both, but I would like new code to go into one direction not two...

I personally find direct comparisons/manipulations far easier to read
than the XLByte* equivalents.

I've still used XLByte* macros, but I agree that plain<  =>  are easier to
read. +1 for using<  =>  in new code.

Do we ever see us changing this from 64-bit integers to something else
? If so, a macro would be much better.

I don't see us changing it again any time soon. Maybe in 20 years time people will start overflowing 2^64 bytes of WAL generated in the lifetime of a database, but I don't think we need to start preparing for that yet.

- Heikki

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to