On 9 January 2013 20:54, Heikki Linnakangas <hlinnakan...@vmware.com> wrote:
> Here's a better idea: > > Let's keep xl_tot_len as it is, but move xl_len at the very end of the WAL > record, after all the backup blocks. If there are no backup blocks, xl_len > is omitted. Seems more robust to keep xl_tot_len, so that you require less > math to figure out where one record ends and where the next one begins. OK, I avoided tampering with xl_len cos its so widely used. Will look. >> Forcing the XLogRecord header to be all on one page makes the format >> more robust and simplifies the code that copes with header wrapping. > -1 on that. That would essentially revert the changes I made earlier. OK, idea dropped. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
