Simon Riggs <si...@2ndquadrant.com> writes: > Overall, the WAL record is MAXALIGN'd, so with 8 byte alignment we > waste 4 bytes per record. Or put another way, if we could reduce > record header by 4 bytes, we would actually reduce it by 8 bytes per > record. So looking for ways to do that seems like a good idea.
I think this is extremely premature, in view of the ongoing discussions about shoehorning logical replication and other kinds of data into the WAL stream. It seems quite likely that we'll end up eating some of that padding space to support those features. So whacking a lot of code around in service of squeezing the existing padding out could very easily end up being wasted work, in fact counterproductive if it degrades either code readability or robustness. Let's wait till we see where the logical rep stuff ends up before we worry about saving 4 bytes per WAL record. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers