On Thu, Mar 28, 2013 at 1:24 AM, Heikki Linnakangas <hlinnakan...@vmware.com> wrote: > On 27.03.2013 18:10, Simon Riggs wrote: >> >> On 27 March 2013 15:35, Heikki Linnakangas<hlinnakan...@vmware.com> >> wrote: >>> >>> Ok, cool. Can you please revert this commit so that we can move on, then? >> >> >> Please explain why you want this reverted, without mentioning the >> other task we agree is required. > > > If an admin can't trust that the file is placed in $PGDATA, it's harder to > determine if a server is a master or a standby. It makes tools that try to > promote / demote a server more complicated, because they need to take this > setting into account. Lastly, it breaks the new pg_basebackup -R > functionality; pg_basebackup will create the recovery.conf file, but it > won't take effect.
This patch breaks also pg_ctl promote because it always checks the existence of $PGDATA/recovery.conf. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
