On 2013-05-13 14:35:47 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > I think we shouldn't check IsPostmasterEnvironment here but instead > > IsBootstrapProcessingMode() since we otherwise can generate oids below > > FirstNormalObjectId in --single mode. > > That is, in fact, exactly what we want to do and must do during initdb. > If you change anything about this code you'll break the way the > post-bootstrap initdb steps assign OIDs.
Well, then we should use some other way to discern from those both cases. If you currently execute CREATE TABLE or something else in --single user mode the database cannot safely be pg_upgraded anymore since the oids might already be used in a freshly initdb'ed cluster in the new version. Or am I missing something here? DROPing and recreating a new index in --single mode isn't that uncommon... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers