On 2013-06-24 07:29:43 -0700, Kevin Grittner wrote: > Andres Freund <and...@2ndquadrant.com> wrote: > > On 2013-06-23 10:32:05 -0700, Kevin Grittner wrote: > > >> The contrib/test_logical_decoding/sql/ddl.sql script is generating > >> unexpected results. For both table_with_pkey and > >> table_with_unique_not_null, updates of the primary key column are > >> showing: > >> > >> old-pkey: id[int4]:0 > >> > >> ... instead of the expected value of 2 or -2. > >> > >> See attached. > > > > Hm. Any chance this was an incomplete rebuild? > > With my hack on the pg_basebackup Makefile, `make -j4 world` is > finishing with no errors and:
Hm. There were some issues with the test_logical_decoding Makefile not cleaning up the regression installation properly. Which might have caused the issue. Could you try after applying the patches and executing a clean and then rebuild? Otherwise, could you try applying my git tree so we are sure we test the same thing? $ git remote add af git://git.postgresql.org/git/users/andresfreund/postgres.git $ git fetch af $ git checkout -b xlog-decoding af/xlog-decoding-rebasing-cf4 $ ./configure ... $ make > > Because I can't reproduce it, despite some playing around... > > Maybe if you can reproduce the build problems I'm seeing.... Tried your recipe but still couldn't... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
>From cdd0ed46ab75768f8a2e82394b04e6392d8ed32a Mon Sep 17 00:00:00 2001 From: Andres Freund <and...@anarazel.de> Date: Mon, 24 Jun 2013 11:52:23 +0200 Subject: [PATCH 1/2] wal_decoding: mergme: Fix pg_basebackup makefile --- src/bin/pg_basebackup/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/bin/pg_basebackup/Makefile b/src/bin/pg_basebackup/Makefile index a41b73c..c251249 100644 --- a/src/bin/pg_basebackup/Makefile +++ b/src/bin/pg_basebackup/Makefile @@ -42,6 +42,9 @@ installdirs: uninstall: rm -f '$(DESTDIR)$(bindir)/pg_basebackup$(X)' rm -f '$(DESTDIR)$(bindir)/pg_receivexlog$(X)' + rm -f '$(DESTDIR)$(bindir)/pg_receivellog$(X)' clean distclean maintainer-clean: - rm -f pg_basebackup$(X) pg_receivexlog$(X) $(OBJS) pg_basebackup.o pg_receivexlog.o pg_receivellog.o + rm -f pg_basebackup$(X) pg_receivexlog$(X) pg_receivellog$(X) \ + pg_basebackup.o pg_receivexlog.o pg_receivellog.o \ + $(OBJS) -- 1.8.2.rc2.4.g7799588.dirty
>From 022c2da1873de2fbc93ae524819932719ca41bdb Mon Sep 17 00:00:00 2001 From: Andres Freund <and...@anarazel.de> Date: Mon, 24 Jun 2013 16:47:48 +0200 Subject: [PATCH 2/2] wal_decoding: mergme: Fix test_logical_decoding Makefile --- contrib/test_logical_decoding/Makefile | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/contrib/test_logical_decoding/Makefile b/contrib/test_logical_decoding/Makefile index 0e7d5d3..3850d44 100644 --- a/contrib/test_logical_decoding/Makefile +++ b/contrib/test_logical_decoding/Makefile @@ -4,18 +4,14 @@ OBJS = test_logical_decoding.o EXTENSION = test_logical_decoding DATA = test_logical_decoding--1.0.sql -ifdef USE_PGXS -PG_CONFIG = pg_config -PGXS := $(shell $(PG_CONFIG) --pgxs) -include $(PGXS) -else +# Note: because we don't tell the Makefile there are any regression tests, +# we have to clean those result files explicitly +EXTRA_CLEAN = -r $(pg_regress_clean_files) + subdir = contrib/test_logical_decoding top_builddir = ../.. include $(top_builddir)/src/Makefile.global include $(top_srcdir)/contrib/contrib-global.mk -endif - -test_logical_decoding.o: test_logical_decoding.c # Disabled because these tests require "wal_level=logical", which # typical installcheck users do not have (e.g. buildfarm clients). -- 1.8.2.rc2.4.g7799588.dirty
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
