Fabien COELHO <coe...@cri.ensmp.fr> writes:
>> Generally, I think that the tests which return a syntax error are of
>> limited value and should probably be dropped.
> I think that it is not that simple: it is a good value to check that the
> syntax error message conveys a useful information for the user, and that
> changes to the parser rules do not alter good quality error messages.
It's good to check those things when a feature is implemented. However,
once it's done, the odds of the bison parser breaking are very low.
Thus, the benefit of testing that over again thousands of times a day
is pretty tiny.
> Moreover, the cost of such tests in time must be quite minimal.
I'm not convinced (see above) and in any case the benefit is even more
minimal.
(Note that semantic errors, as opposed to syntax errors, are a different
question.)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
