On 10/14/2013 05:44 PM, Andres Freund wrote:
On 2013-10-10 12:54:23 -0400, Andrew Dunstan wrote:
On 09/19/2013 06:12 PM, Pavel Stehule wrote:
2013/9/16 Satoshi Nagayasu <sn...@uptime.jp <mailto:sn...@uptime.jp>>
I'm looking at this patch, and I have a question here.
Should "DROP TRIGGER IF EXISTS" ignore error for non-existing trigger
and non-existing table? Or just only for non-existing trigger?
My opinion is so, both variants should be ignored - it should be fully
fault tolerant in this use case.
This thread seems to have gone cold, but I'm inclined to agree with Pavel.
If the table doesn't exist, neither does the trigger, and the whole point of
the 'IF EXISTS' variants is to provide the ability to issue DROP commands
that don't fail if their target is missing.
-1, this seems to likely to just hide typos.
So if I say
DROP TRIGGER IF EXISTS foo ON bar;
you're ok with succeeding if foo is a typo, but not if bar is?
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
