On Sat, Jan 25, 2014 at 5:25 PM, Andres Freund <and...@2ndquadrant.com> wrote: >> Looking over patch 0002, I see that there's code to allow a walsender >> to create or drop a physical replication slot. Also, if we've >> acquired a replication slot, there's code to update it, and code to >> make sure we disconnect from it, but there's no code to acquire it. I >> think maybe the hunk in StartReplication() is supposed to be calling >> ReplicationSlotAcquire() instead of ReplicationSlotRelease(), > > Uh. You had me worried here for a minute or two, a hunk or two earlier > than the ReplicationSlotRelease() you mention. What probably confused > you is that StartReplication only returns once all streaming is > finished. Not my idea...
No, what confuses me is that there's no call to ReplicationSlotAcquire() in patch 0001 or patch 0002.... the function is added but not called. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
