On Wed, Jan 29, 2014 at 12:35 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Jan 29, 2014 at 10:55 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera >> <alvhe...@2ndquadrant.com> wrote: >>> >>> Anybody knows about this patch? >>> http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp >> >> Though I'm not sure whether Nagayasu is still working on that patch, >> it's worth thinking to introduce that together with pg_stat_archiver. > This patch uses globalStats to implement the new stat fields for > walwriter, I think that we should use a different structure for > clarity and to be in-line with what is done now with the archiver > part.
Is there clear reason why we should define separate structure for each global stats view? If we introduce something like pg_stat_walwriter later, it seems better to use only one structure, i.e., globalStats, for all global stats views. Which would simplify the code and can reduce the number of calls of fwrite()/fread(). Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers