On Sat, Feb 8, 2014 at 10:16 PM, Peter Eisentraut <pete...@gmx.net> wrote:
> Clearly, we will need to figure out something about how to require this
> module, and possibly others in the future, as we expand the tests.
> Having configure check for it is not necessarily the best solution --
> What is configure supposed to do if it can't find it?
> We could perhaps use Test::More skip_all to just skip these tests
> depending on what modules are available.  And add appropriate
> documentation.

I would think we would want to keep the number of dependencies
relatively small.  If it gets large, that just means that nobody will
be able to run the tests.  And -1 for the idea of running only the
tests that we can given what's installed; that'll make it very easy to
not run all the tests, which kind of defeats the purpose of having
them IMHO.  We should just "require" whatever we need and let the test
run abort if it's not available.

Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to