On 02/11/2014 11:04 PM, Amit Kapila wrote: > On Tue, Feb 11, 2014 at 11:01 AM, Craig Ringer <cr...@2ndquadrant.com> wrote: >> On 02/11/2014 01:28 PM, Tom Lane wrote: >>> If there are no objections, I'll push this patch into HEAD tomorrow, >>> along with the upthread patches from Craig Ringer and Marco Atzeri. >>> We might as well see if this stuff is going to work ... >> >> I'd love to test my patch properly before pushing it, but my dev machine >> is going to need a total teardown and rebuild, > > I can do the test of your patch/idea, please confirm if below steps are > sufficient: > a. Change manually postgres.def file and add DATA for MainLWLockArray. > (Will it be sufficient to change manually or should I apply your patch)
No, you must rebuild "postgres", or at least re-generate the .DEF file and re-link postgres.exe to generate a new import library (.lib) for it. It'll be easiest to just recompile. > b. Rebuild pg_buffercache module Yes. > c. Test pg_buffercache if it can access the variable. Yes, though it should fail to link if there's no PGDLLIMPORT. > d. If above works, then run 'check'. Yes, after adding the PGDLLIMPORT and re-generating the postgres .lib by relinking or recompiling. > If I understand correctly your patch is intended to resolve PGDLLIMPORT > problem, right? No, just make it obvious where such imports are missing. I can't see a way to completely make it invisible with the MS toolchain. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers