On Wed, Jan 15, 2014 at 8:12 PM, MauMau <maumau...@gmail.com> wrote: > From: "Asif Naeem" <anaeem...@gmail.com> > >> As you have > > followed destroy_tablespace_directories() function, Is there any specific > reason not to use same logic to detect type of the file/link i.e. > "(lstat(linkloc, &st) == 0 && S_ISDIR(st.st_mode))", It also seems have > more appropriate error message i.e. > > Thanks for reviewing and testing the patch. Yes, at first I did what you > mentioned, but modified the patch according to some advice in the mail > thread. During redo, create_tablespace_directories() needs to handle the > case where the $PGDATA/pg_tblspc/xxx is not a symlink but a directory even > on UNIX/Linux. Please see TablespaceCreateDbspace is(). > destroy_tablespace_directories() doesn't have to handle such situation.
If create_tablespace_directories() needs to handle with directory both on Windows/Linux, then shouldn't it be a runtime check as in your first version rather than compile time check? Also isn't that the reason why destroy_tablespace_directories() have similar check? With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
