On 2014-03-17 12:57:15 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > On 2014-03-17 12:50:37 -0400, Tom Lane wrote: > >> I guess the real question is why such a prototype is in tqual.h in > >> the first place. ISTM this should be pushed somewhere specific to > >> reorderbuffer.c. I'm -1 on having struct HTAB bleed into tqual.h > >> via either of the methods you suggest. > > > It's the only logical decoding specific routine that's called by tqual.c > > which doesn't need anything else from reorderbuffer. I'd like to avoid > > more stuff bleeding in there... > > Instead, you'd like HTAB to bleed into everything that uses tqual.h?
Meh. a struct forward declaration isn't exactly a significant thing to expose. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
