On 2014-03-17 12:56:12 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > On 2014-03-17 13:40:53 -0300, Alvaro Herrera wrote: > >> There is of course a third choice which is to dictate that this function > >> ought to be declared in reorderbuffer.h; but that would have the > >> unpleasant side-effect that tqual.c would need to #include that. > > > I am pretty clearly against this. > > Let me get this straight. reorderbuffer.c exports a function that needs > to be used by tqual.c. The obvious method to do this is to declare the > function in reorderbuffer.h and have tqual.c #include that. Apparently > you think it's better to have tqual.h declare the function. How is that > not 100% backwards? Even worse that it requires more header-inclusion > bloat for some functionality entirely unrelated to snapshots?
I don't think cmin/cmax are entirely unrelated to tuple visibility. If it didn't require exposing reorderbuffer.c internals, it's implementation should have been in tqual.c. And a struct HTAB; wouldn't require including a header. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
