On Tue, Mar 18, 2014 at 04:17:53PM +0000, Simon Riggs wrote: > > While I am not a fan of backpatching, the fact we are ignoring errors in > > some critical cases seems the non-cosmetic parts should be backpatched. > > pg_resetxlog was not an offender here; its coding was sound. > > We shouldn't be discussing backpatching a patch that contains changes > to coding style.
I was going to remove the coding style changes to pg_resetxlog from the backpatched portion. > ISTM we should change the code with missing checks to adopt the coding > style of pg_resetxlog, not the other way around. > > I assume you or Kevin have this in hand and you don't want me to apply > the patch? (Since it was originally my bug) I know the email subject says pg_archivecleanup but the problem is all over our code. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
