On Wed, Mar 26, 2014 at 11:23 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Thu, Mar 27, 2014 at 1:39 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Mon, Mar 24, 2014 at 9:02 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: >>> MarkBufferDirty() always increment BufferUsage counter >>> (shared_blks_dirtied) for dirty blocks whenever it dirties any >>> block, whereas same is not true for MarkBufferDirtyHint(). >>> Is there any particular reason for not incrementing >>> shared_blks_dirtied in MarkBufferDirtyHint()? >> >> Hmm, I think that's a bug, dating back to this commit: >> >> commit 2254367435fcc4a31cc3b6d8324e33c5c30f265a > > Right. > Do you think the fix attached in my previous mail is appropriate? > http://www.postgresql.org/message-id/CAA4eK1KQQSpNmfxg8Cg3-JZD23Q4Ee3iCsuLZGekH=dnagp...@mail.gmail.com
Looks right to me. Committed and back-patched to 9.2. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
