On 2014-04-22 22:37:37 -0400, Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > I had to revert this patch. It causes a failure in the > > /contrib/test_decoding regression test. > > On closer inspection, it was simply pfree'ing the wrong pointer.
Thanks for fixing. > I fixed that and also undid the allocation in a different memory > context, which didn't seem to be a particularly good idea, unless > you've got a specific reason why CurrentMemoryContext would be the > wrong place for a transient allocation. That should be fine. I don't see any reason not to use palloc. logical_rewrite_log_mapping() has to allocate longer living memory, I guess it was copied from there. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
