On 2014-05-05 09:52:33 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > >>> Aren't you potentially dereferencing a NULL pointer here? > > >> Hmm -- I thought the GUC machinery would make sure cluster_name either > >> pointed to the default I provided, an empty string, or a string read from > >> the configuration file. Perhaps I need to go and read up on how GUCs work. > > > That's true - but I am not sure you can guarantee it's only called after > > the GUC machinery has started up. > > The elog code MUST be able to work before GUC initialization is done. > What do you think will happen if we fail to open postgresql.conf, > for example?
But elog. shouldn't call init_ps_display(), right? Anyway, I am all for initializing it sensibly, after all it was I that suggested doing so above... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
