Hi all,

MSVC build uses two configuration perl files when running:
config_default.pl and config.pl. The former is mandatory and is
present in the code tree, while the latter can be used to override
settings with some custom parameters. As far as I understand from the
docs, config.pl should be used only in a custom environment and should
never be committed. Hence, why not adding a .gitignore in
src/tools/msvc and ignoring this file? This will prevent unfortunate
commits that could include this file and impact the devs working on
Windows. The patch attached does that. I think that it should be
back-patched for consistency across branches..
From 31dc80972a2ea626b63ab22f3c2c8735e15f9582 Mon Sep 17 00:00:00 2001
From: Michael Paquier <mich...@otacoo.com>
Date: Mon, 12 May 2014 15:06:01 +0900
Subject: [PATCH] Ignore config.pl in src/tools/msvc

config.pl can be used to override build settings when using MSVC and
should be never be included in the code tree.
 src/tools/msvc/.gitignore | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 src/tools/msvc/.gitignore

diff --git a/src/tools/msvc/.gitignore b/src/tools/msvc/.gitignore
new file mode 100644
index 0000000..dc9d8c0
--- /dev/null
+++ b/src/tools/msvc/.gitignore
@@ -0,0 +1,2 @@
+# Custom configuration file for MSVC build

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to