On Mon, May 12, 2014 at 3:08 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> Hi all,
> MSVC build uses two configuration perl files when running:
> config_default.pl and config.pl. The former is mandatory and is
> present in the code tree, while the latter can be used to override
> settings with some custom parameters. As far as I understand from the
> docs, config.pl should be used only in a custom environment and should
> never be committed. Hence, why not adding a .gitignore in
> src/tools/msvc and ignoring this file? This will prevent unfortunate
> commits that could include this file and impact the devs working on
> Windows. The patch attached does that. I think that it should be
> back-patched for consistency across branches..
Actually I am sending an updated patch as buildenv.pl enters in the
same category as config.pl.
From d1e22a13cb732952facc5fa563bfe44d25437eff Mon Sep 17 00:00:00 2001
From: Michael Paquier <mich...@otacoo.com>
Date: Mon, 12 May 2014 16:04:11 +0900
Subject: [PATCH] Ignore config.pl and buildenv.pl in src/tools/msvc

config.pl and buildenv.pl can be used to override build settings when
using MSVC and should be never be included in the code tree.
 src/tools/msvc/.gitignore | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 src/tools/msvc/.gitignore

diff --git a/src/tools/msvc/.gitignore b/src/tools/msvc/.gitignore
new file mode 100644
index 0000000..3a7a928
--- /dev/null
+++ b/src/tools/msvc/.gitignore
@@ -0,0 +1,3 @@
+# Custom configuration file for MSVC build

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to