On 2014-06-18 18:10:34 +0530, Rahila Syed wrote:
> Hello ,
> >I have a few preliminary comments about your patch
> Thank you for review comments.
> >the patch creates src/common/lz4/.travis.yml, which it shouldn't.
> Agree. I will remove it.
> >Shouldn't this use palloc?
> palloc() is disallowed in critical sections and we are already in CS while
> executing this code. So we use malloc(). It's OK since the memory is
> allocated just once per session and it stays till the end.

malloc() isn't allowed either. You'll need to make sure all memory is
allocated beforehand


Andres Freund

 Andres Freund                     http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to