On 4 July 2014 19:11, Abhijit Menon-Sen <a...@2ndquadrant.com> wrote:
> Updated patch attached, thanks.
> Amit: what's your conclusion from the review?
Other than some minor comments as mentioned below, I don't have any more
issues, it looks all good.
XLogLockBlockRangeForCleanup() function header comments has the function
name spelled: XLogBlockRangeForCleanup
In GetBufferWithoutRelcache(), we can call BufferDescriptorGetBuffer(buf)
rather than BufferDescriptorGetBuffer(&BufferDescriptors[buf_id]).
> -- Abhijit