2014-08-28 13:20 GMT+02:00 Andres Freund <and...@2ndquadrant.com>: > Hi, > > On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote: > > Hi > > > > I chose \? xxx, because it is related to psql features. I wrote commands: > > > > \? options > > \? variables > > > > comments? > > Generall I like it. > > Some stuff I changed: > * I rephrased the sgml changes > * s/Printing options/Display options/. Or maybe "Display influencing > variables"? That makes it clearer why they're listed under > --help-variables. > * I added \? commands as an alias for a plain \? > That way the scheme can sensibly be expanded. > * I renamed help_variables() to be inline with the surrounding functions. > > Stuff I wondered about: > * How about making it --help=variables instead of --help-variables? That >
I am sorry, I don't like this idea --help-variables is much more usual for cmd line > * Do we really need the 'Report bugs to' blurb for --help-variables? > > * Since we're not exhaustive about documenting environment variales, do > we really need to document TMPDIR and SHELL? > * Shouldn't we document that PROMPT1 is the standard prompt, PROMPT2 is > for already started statements, and PROMPT3 is for COPY FROM STDIN? > I don't see TMPDIR, SHELL as really important in this position Pavel > > Looks like it's commitable next round. > > I've attached a incremental patch. > > Greetings, > > Andres Freund > > -- > Andres Freund http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services >
