Marko Tiikkaja wrote: > On 2014-09-02 22:24, Alvaro Herrera wrote: > >Marko Tiikkaja wrote: > >>Do we have some kind of an agreement on what this patch should look > >>like? Is someone going to prepare an updated patch? Vik? > > > >I think the only issue left for this to be committable is reindexdb > >--all previously mentioned. > > I scanned through the patch and found the exit_nicely() business a > bit weird, so that might be another thing worth looking at.
Yeah, just rip that out and do PQfinish(conn); exit(1); as other exit paths do, I'd think. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers