Dean, * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > On 20 September 2014 14:08, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Sat, Sep 20, 2014 at 7:03 AM, Dean Rasheed <dean.a.rash...@gmail.com> > > wrote: > >> Fortunately it looks pretty trivial though. The patch attached fixes > >> the above test cases. > >> Obviously this needs to be fixed in 9.4 and HEAD. > > Wouldn't it be better if bundled with some regression tests?
Agreed.
> Yeah OK, fair point. Here are some tests that cover that code path.
> I've also thrown in a test with prepared statements, although that
> case was already working, it seemed worth checking.
Thanks! Looks good, but will review in more depth, address the other
comments on this thread (typo, adding more documentation) and
investigate the results from the Coverity run this morning this evening
and should be able to get everything addressed in the next couple days.
Obviously, I'll be back-patching this fix to 9.4 too.
Thanks again!
Stephen
signature.asc
Description: Digital signature
