On 2014-09-29 11:02:49 -0400, Robert Haas wrote:
> On Mon, Sep 29, 2014 at 8:36 AM, Andres Freund <and...@anarazel.de> wrote:
> > 1) I don't think it's a good idea to put the full page write compression
> >    into struct XLogRecord.
> Why not, and where should that be put?

Hah. I knew that somebody would pick that comment up ;)

I think it shouldn't be there because it looks trivial to avoid putting
it there. There's no runtime and nearly no code complexity reduction
gained by adding a field to struct XLogRecord. The best way to do that
depends a bit on how my complaint about the removed error checking
during reading the backup block data is resolved.


Andres Freund

 Andres Freund                     http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to