> On 7 November 2014 at 22:46, Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Oct 27, 2014 at 2:35 AM, Kouhei Kaigai <kai...@ak.jp.nec.com> > wrote: > >>> FYI, patch v12 part 2 no longer applies cleanly. > >>> > >> Thanks. I rebased the patch set according to the latest master branch. > >> The attached v13 can be applied to the master. > > > > I've committed parts 1 and 2 of this, without the documentation, and > > with some additional cleanup. I am not sure that this feature is > > sufficiently non-experimental that it deserves to be documented, but > > if we're thinking of doing that then the documentation needs a lot > > more work. I think part 3 of the patch is mostly useful as a > > demonstration of how this API can be used, and is not something we > > probably want to commit. So I'm not planning, at this point, to spend > > any more time on this patch series, and will mark it Committed in the > > CF app. > > > I'm very concerned about the state of this feature. No docs, no examples, > and therefore, no testing. This standard of code is much less than I've > been taught is the minimum standard on this project. > > There are zero docs, even in README. Experimental feature, or not, there > MUST be documentation somewhere, in some form, even if that is just on the > Wiki. Otherwise how it will ever be used sufficiently to allow it to be > declared fully usable? > The reason why documentation portion was not yet committed is, sorry, it is due to quality of documentation from the standpoint of native English speaker. Now, I'm writing up a documentation stuff according to the latest code base, please wait for several days and help to improve.
> The example contrib module was not committed and I am advised no longer > works. > May I submit the contrib/ctidscan module again for an example? Thanks, -- NEC OSS Promotion Center / PG-Strom Project KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
