On Sat, Dec 13, 2014 at 10:39 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Tatsuo Ishii <is...@postgresql.org> writes: >> Currently pgbench -f (run custom script) executes vacuum against >> pgbench_* tables before stating bench marking if -n (or --no-vacuum) >> is not specified. If those tables do not exist, pgbench fails. To >> prevent this, -n must be specified. For me this behavior seems insane >> because "-f" does not necessarily suppose the existence of the >> pgbench_* tables. Attached patch prevents pgbench from exiting even >> if those tables do not exist. > > I don't particularly care for this approach. I think if we want to > do something about this, we should just make -f imply -n. Although > really, given the lack of complaints so far, it seems like people > manage to deal with this state of affairs just fine. Do we really > need to do anything?
I would vote for changing nothing. If we make -f imply -n, then what happens if you have a script which is a slight variant of the default script and you *don't* want -n? Then we'll have to add yet another pgbench option to select the default behavior, and I don't know that the marginal usability gain of getting to leave out -n sometimes would be enough to justify having to remember another switch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
