Andres Freund <and...@2ndquadrant.com> writes: >> I personally still think that a comment above sbufdesc's definition >> would be sufficient for now. But whatever. I'll enforce 64byte padding >> on 64bit platforms, and do nothing on 32bit platforms.
> Patch doing that attached. Surely the sizeof() in BufferShmemSize needs to be sizeof(BufferDescPadded) now? Also, the macro is unnecessarily unsafe for use in #if tests; why not something like #define BUFFERDESC_PADDED_SIZE (SIZEOF_VOID_P == 8 ? 64 : 32) Otherwise it looks reasonably sane to me, just in a quick once-over; I didn't test. regards, tom lane -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers