Hi all, When using install.bat with a path containing spaces, I got surprised by a couple of errors. 1) First with this path: $ install "c:\Program Files\pgsql" I am getting the following error: Files\pgsql""=="" was unexpected at this time. This is caused by an incorrect evaluation of the first parameter in install.bat. 2) After correcting the first error, the path is truncated to c:\Program because first argument value does not seem to be correctly parsed when used with install.pl.
Attached is a patch fixing both problems. I imagine that it would be good to get that backpatched. Regards, -- Michael
diff --git a/src/tools/msvc/install.bat b/src/tools/msvc/install.bat index bed08f1..29c6c31 100644 --- a/src/tools/msvc/install.bat +++ b/src/tools/msvc/install.bat @@ -1,7 +1,7 @@ @echo off REM src/tools/msvc/install.bat -if NOT "%1"=="" GOTO RUN_INSTALL +if NOT [%1]==[/?] GOTO RUN_INSTALL echo Invalid command line options. echo Usage: "install.bat <path>" @@ -20,7 +20,7 @@ CALL bldenv.bat del bldenv.bat :nobuildenv -perl install.pl "%1" %2 +perl install.pl %1 %2 REM exit fix for pre-2003 shell especially if used on buildfarm if "%XP_EXIT_FIX%" == "yes" exit %ERRORLEVEL%
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
